Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use custom SSH key #448

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

pohly
Copy link
Collaborator

@pohly pohly commented Jul 8, 2021

Using the default failed the CNCF's CLA check:

  remote: error: GH006: Protected branch update failed for refs/heads/gh-pages.
  remote: error: Required status check "cla/linuxfoundation" is expected.
  To https://github.com/kubernetes-csi/docs.git
   ! [remote rejected] github-pages-deploy-action/zypejdthm -> gh-pages (protected branch hook declined)

This did not happen for TravisCI which authenticated via a custom
SSH key, so the same approach is now also used for GitHub Actions.

Using the default failed the CNCF's CLA check:
  remote: error: GH006: Protected branch update failed for refs/heads/gh-pages.
  remote: error: Required status check "cla/linuxfoundation" is expected.
  To https://github.com/kubernetes-csi/docs.git
   ! [remote rejected] github-pages-deploy-action/zypejdthm -> gh-pages (protected branch hook declined)

This did not happen for TravisCI which authenticated via a custom
SSH key, so the same approach is now also used for GitHub Actions.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2021
@pohly
Copy link
Collaborator Author

pohly commented Jul 8, 2021

/assign @xing-yang

@msau42
Copy link
Collaborator

msau42 commented Jul 8, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@pohly
Copy link
Collaborator Author

pohly commented Jul 8, 2021

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4e5dc33 into kubernetes-csi:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants