[WIP] feat: client generated by openapi-generator #738

tomplus · 2019-01-27T01:12:02Z

The client has been generated by openapi-generator instead of swagger-codegen.

k8s-ci-robot · 2019-01-27T01:12:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tomplus
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yliaog

If they are not already assigned, you can assign the PR to them by writing /assign @yliaog in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tomplus · 2019-01-27T01:37:01Z

kubernetes/.openapi-generator/COMMIT

@@ -0,0 +1,2 @@
+Requested Commit: v3.3.4


kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed).

tomplus · 2019-01-27T01:37:43Z

kubernetes/client/api/__init__.py

+
+# flake8: noqa
+
+# import apis into api package


This packages is renamed from apis to api.

Out of curiosity, why did you change it from apis to api?

tomplus · 2019-01-27T01:38:50Z

setup.py

@@ -56,7 +56,7 @@
 tests_require=TESTS_REQUIRES,
 extras_require=EXTRAS,
 packages=['kubernetes', 'kubernetes.client', 'kubernetes.config',
- 'kubernetes.watch', 'kubernetes.client.apis',
+ 'kubernetes.watch', 'kubernetes.client.api',


apis -> api

tomplus · 2019-01-27T01:39:37Z

kubernetes/e2e_test/test_batch.py

@@ -16,7 +16,7 @@
 import uuid

 from kubernetes.client import api_client
-from kubernetes.client.apis import batch_v1_api
+from kubernetes.client.api import batch_v1_api


apis -> api here and in another e2e tests too.

tomplus · 2019-01-27T01:41:32Z

scripts/rest_client_patch.diff

 --- a/kubernetes/client/rest.py
 +++ b/kubernetes/client/rest.py
-@@ -152,6 +152,10 @@ class RESTClientObject(object):
+@@ -155,6 +155,10 @@ class RESTClientObject(object):


It needs to be updated to apply this patch by update_client.sh

tomplus · 2019-01-27T01:47:28Z

kubernetes/client/__init__.py

 """


 from __future__ import absolute_import

-# import models into sdk package
-from .models.admissionregistration_v1beta1_service_reference import AdmissionregistrationV1beta1ServiceReference


relative vs. absolute imports

tomplus · 2019-01-27T01:49:21Z

kubernetes/client/api/admissionregistration_v1alpha1_api.py

-import sys
-import os
-import re
+import re # noqa: F401


There are a lot of changes which clean the code (unused imports, long lines etc.).

fejta-bot · 2019-04-29T19:47:03Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

tomplus · 2019-04-29T19:51:38Z

/remove-lifecycle stale

roycaihw · 2019-07-02T17:56:38Z

/cc

roycaihw

looks pretty neat. I checked the apis and the models. It seems that the only major interface change is the package getting renamed.

was there any file contributed a lot to the line number diff (9620 from +93,422 −103,042)? I didn't see huge file getting deleted. It's probably accumulated as we cut a couple of lines from the hundreds of files.

I re-triggered the tests and the test failure looks unrelated-- more like server-side problem than client-side

kubernetes/client/api/authentication_v1_api.py

scottilee · 2019-07-26T04:01:41Z

kubernetes/.openapi-generator/COMMIT

@@ -0,0 +1,2 @@
+Requested Commit: v3.3.4
+Actual Commit: 2353d71d4b02be6dbabe25aac1a9e56eb3b812a2


Since its been a while can you bump this to v4.0.3, commit 203fc812bda4267020165e656f55185f72df4cc0?

Also just curious, how often would the version need to be bumped in the future?

I believe that we rarely bump the version of swagger-codegen right now.

scottilee · 2019-07-26T04:03:46Z

kubernetes/README.md

@@ -17,9 +17,9 @@ Python 2.7 and 3.4+
 If the python package is hosted on Github, you can install directly from Github

 ```sh
-pip install git+https://github.com/kubernetes-client/python.git
+pip install git+https://github.com/kubernetes-kubernetes.client/python.git


Why are these changed to this weird URL?

scottilee · 2019-07-26T04:07:00Z

kubernetes/client/__init__.py

-from .models.v2beta2_resource_metric_source import V2beta2ResourceMetricSource
-from .models.v2beta2_resource_metric_status import V2beta2ResourceMetricStatus
-from .models.version_info import VersionInfo
+__version__ = "9.0.0-snapshot"


Shoudn't this be: "10.0.0-snapshot"?

scottilee · 2019-07-26T04:12:51Z

kubernetes/README.md

@@ -68,7 +70,7 @@ except ApiException as e:

 ## Documentation for API Endpoints

-All URIs are relative to *https:https://localhost*
+All URIs are relative to *http:https://localhost*


Also curious why it's http now instead of https?

scottilee · 2019-07-26T04:16:22Z

The kubernetes/README.md Requirements section says "Python 2.7 and 3.4+" but 3.4 is deprecated (refer to #807). Is there a way to fix this?

roycaihw · 2019-12-03T18:56:42Z

we've migrated to openapi-generator

/close

k8s-ci-robot · 2019-12-03T18:56:44Z

@roycaihw: Closed this PR.

In response to this:

we've migrated to openapi-generator

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feat: client generated by openapi-generator

7b246cf

k8s-ci-robot requested review from caesarxuchao and yliaog January 27, 2019 01:12

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 27, 2019

tomplus changed the title ~~feat: client generated by openapi-generator~~ [WIP] feat: client generated by openapi-generator Jan 27, 2019

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2019

tomplus mentioned this pull request Jan 27, 2019

feat: switch python client to use openapi-generator kubernetes-client/gen#97

Merged

tomplus commented Jan 27, 2019

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2019

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2019

k8s-ci-robot requested a review from roycaihw July 2, 2019 17:56

roycaihw reviewed Jul 3, 2019

View reviewed changes

kubernetes/client/api/authentication_v1_api.py Show resolved Hide resolved

roycaihw mentioned this pull request Jul 17, 2019

Unsupported Media Type (HTTP 415) when patching custom resources #866

Closed

scottilee reviewed Jul 26, 2019

View reviewed changes

houqp mentioned this pull request Aug 8, 2019

Refresh token/api-key periodically #741

Closed

k8s-ci-robot closed this Dec 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] feat: client generated by openapi-generator #738

[WIP] feat: client generated by openapi-generator #738

tomplus commented Jan 27, 2019

k8s-ci-robot commented Jan 27, 2019

tomplus Jan 27, 2019

tomplus Jan 27, 2019

scottilee Jul 26, 2019

tomplus Jan 27, 2019

tomplus Jan 27, 2019

tomplus Jan 27, 2019

tomplus Jan 27, 2019

tomplus Jan 27, 2019

fejta-bot commented Apr 29, 2019

tomplus commented Apr 29, 2019

roycaihw commented Jul 2, 2019

roycaihw left a comment

scottilee Jul 26, 2019

scottilee Jul 26, 2019

micw523 Aug 3, 2019

scottilee Jul 26, 2019

scottilee Jul 26, 2019

scottilee Jul 26, 2019

scottilee commented Jul 26, 2019

roycaihw commented Dec 3, 2019

k8s-ci-robot commented Dec 3, 2019

		@@ -0,0 +1,2 @@
		Requested Commit: v3.3.4
		Actual Commit: 2353d71d4b02be6dbabe25aac1a9e56eb3b812a2

[WIP] feat: client generated by openapi-generator #738

[WIP] feat: client generated by openapi-generator #738

Conversation

tomplus commented Jan 27, 2019

k8s-ci-robot commented Jan 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fejta-bot commented Apr 29, 2019

tomplus commented Apr 29, 2019

roycaihw commented Jul 2, 2019

roycaihw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottilee commented Jul 26, 2019

roycaihw commented Dec 3, 2019

k8s-ci-robot commented Dec 3, 2019