update image tags

[thesuperzapper]

Which issue is resolved by this Pull Request:

This resolves #1553 (for the components that belong to wg-notebook)

Description of your changes:

Updates the image tags for the following applications:

• admission-webhook
• centraldashboard
• jupyter-web-app
• notebook-controller
• kfam
• profile-controller

Checklist:

• Unit tests have been rebuilt:
  1. cd manifests/tests
  2. make generate-changed-only
  3. make test

[thesuperzapper]

@Bobgy @Jeffwan can you review? (this needs to get into Kubeflow 1.2)

[Jeffwan]

@thesuperzapper Thanks taking care of this

Is there a change list for these images?

[Jeffwan]

I will cut a new rc release once they are merged into 1.2

/lgtm

[Jeffwan]

Can we also include this change? https://github.com/kubeflow/kubeflow/pull/5404/files

Metadata has already removed UI service. We need to have this change in central dashboard

[thesuperzapper]

@Jeffwan I need someone to approvve adding me to OWNERs (see kubeflow/kubeflow#5408) so I can approve your PR.

[thesuperzapper]

Also @Jeffwan, some stacks have hard coded these image tags in their manifests, we should get them to remove these:

• IBM
• Azure

[Jeffwan]

/cc @animeshsingh @Tomcli @pvaneck @berndverst @PatrickXYS

Please have a check on the hard coded images. some components images needs to be updated

[Jeffwan]

@thesuperzapper Do you have the permission to approve changes in these control plane components? Let me know when it's ready to merge

[thesuperzapper]

@Bobgy, I need someone in the root OWNERS file to approve this

[Bobgy]

/lgtm
/approve
Sure

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Bobgy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[animeshsingh]

@pvaneck will address the hardcoded image tags for IBM images

[berndverst]

@thesuperzapper @Jeffwan there were no hardcoded image tags in the Azure stack or kfdefs. Where did you see that there was something hard coded?

The Azure stack refers to the shared component bases in the root of the repo and does not override images.

[thesuperzapper]

@berndverst here is a link:
https://github.com/kubeflow/manifests/blob/master/stacks/azure/application/jupyter-web-app/base/kustomization.yaml#L10

[thesuperzapper]

@Jeffwan I also see that openshift stack has some hard coded as well.

PS: the trick to finding them is searching for newTag:

[Jeffwan]

@nakfour Can you follow @thesuperzapper 's suggestion and update master image to your v1.2 manifest?

[nakfour]

@Jeffwan we use a custom JH image which we will submit a PR to update soon.