Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KFServing and KNative manifests Owners files #1311

Merged
merged 9 commits into from
Jun 27, 2020

Conversation

animeshsingh
Copy link
Contributor

No description provided.

@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@animeshsingh
Copy link
Contributor Author

@adrian555 @Tomcli @yuzisun please lgtm

additionally @yuzisun do we want to add someone else from bloomberg?

@animeshsingh
Copy link
Contributor Author

/verify-owners

@adrian555
Copy link
Member

/lgtm

@Tomcli
Copy link
Member

Tomcli commented Jun 23, 2020

/lgtm

Copy link
Contributor

@krishnadurai krishnadurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@animeshsingh isn't this a duplicate?
#1232

@animeshsingh
Copy link
Contributor Author

thanks @krishnadurai for pointing that

didn't see that before - but I don't expect these files to be duplicate of OWNERS file in actual application repos - the focus here is folks who would be focussing on "integration" and "integration-testing" with Kubeflow as opposed to development of application itself.

cc @yuzisun

@animeshsingh
Copy link
Contributor Author

on that note, ideally @krishnadurai you should be in KNative owners file as well, if you don't mind to be added

@krishnadurai
Copy link
Contributor

@animeshsingh go ahead to add my name.

@yuzisun
Copy link
Member

yuzisun commented Jun 26, 2020

/lgtm

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@animeshsingh: 1 invalid OWNERS file

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative/OWNERS Show resolved Hide resolved
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@animeshsingh: 1 invalid OWNERS file

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative/OWNERS Show resolved Hide resolved
@animeshsingh
Copy link
Contributor Author

/verify-owners

@krishnadurai
Copy link
Contributor

/lgtm

@animeshsingh
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0ad37ed into kubeflow:master Jun 27, 2020
k8s-ci-robot pushed a commit that referenced this pull request Jul 31, 2020
…m_dex support #1355: add myself to kfdef/OWNERS #1428: add multi-user kfdef configurations Cherry pick of #1311 #1336 #1355 #1428 on v1.1-branch. #1311: KFServing Owners file #1336: kfctl_ibm_dex support #1355: add myself to kfdef/OWNERS #1428: add multi-user kfdef configurations (#1441)

* KFServing Owners file

* Update OWNERS

* knative owners

* Update OWNERS

* Update OWNERS

* Update OWNERS

* Update OWNERS

* Update OWNERS

* Update OWNERS

* kfctl_ibm_dex support

* add dex config

* fix

* update default config

* update dex-config.yaml

* add support for kustomize fns

* update docker image repo

* update oidc-authservice

* set default userid-header

* update tests

* add myself to kfdef/OWNERS

* add multi-user kfdef configurations

* replace env with envs

* update multi-user

* update with namespaces

* different ClusterRbacConfig for dex and non-dex

* add v1.1.0 ibm kfdef

* update generated tests

* update test expected data

Co-authored-by: Animesh Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants