This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
[IBM] limit reconcile requests to specific kfdef update events and a couple of operator fixes #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pvaneck
reviewed
Oct 27, 2020
moficodes
approved these changes
Oct 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrian555, moficodes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
animeshsingh
added a commit
to animeshsingh/manifests
that referenced
this pull request
Nov 11, 2020
Will be responsible for maintaining manifests for KFServing, OpenShift, IKS etc. PRs merged: kubeflow#1515 kubeflow#1575 kubeflow#1580 kubeflow#1617 Reviews: kubeflow#1582 kubeflow#1621 kubeflow#1625 kubeflow#1627 kubeflow#1628 kubeflow/kfctl#419
animeshsingh
added a commit
to animeshsingh/internal-acls
that referenced
this pull request
Nov 11, 2020
PRs: Manifest (kubeflow/manifests#1603) Website (kubeflow/website#1752) Reviews: Manifest(kubeflow/manifests#1621, kubeflow/manifests#1594, kubeflow/manifests#1582, kubeflow/manifests#1567) kfctl(kubeflow/kfctl#419) Website(kubeflow/website#2327) Issue Triage: kfctl(kubeflow/kfctl#428, kubeflow/kfctl#424, kubeflow/kfctl#418)
k8s-ci-robot
pushed a commit
to kubeflow/internal-acls
that referenced
this pull request
Nov 11, 2020
PRs: Manifest (kubeflow/manifests#1603) Website (kubeflow/website#1752) Reviews: Manifest(kubeflow/manifests#1621, kubeflow/manifests#1594, kubeflow/manifests#1582, kubeflow/manifests#1567) kfctl(kubeflow/kfctl#419) Website(kubeflow/website#2327) Issue Triage: kfctl(kubeflow/kfctl#428, kubeflow/kfctl#424, kubeflow/kfctl#418)
k8s-ci-robot
pushed a commit
to kubeflow/manifests
that referenced
this pull request
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles these issues:
when there is an update event caught for the KfDef CR, check whether they are one of the three changes to the KfDef that the operator is supposed to handle. Others will be ignored. This is done to prevent any false update to the KfDef that could cause the operator to redeploy the Kubeflow.
fix the logic to check whether a namespace already exists and whether the kfdef label should be applied or not.
change the master branch's operator image tag to
:latestso it will not impact the current release.