Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to run cli from the appscode/grafana-dashboards CI #766

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

sayedppqq
Copy link
Contributor

No description provided.

pkg/cmds/monitor.go Outdated Show resolved Hide resolved
pkg/monitor/dashboard/db.go Show resolved Hide resolved
@ArnobKumarSaha ArnobKumarSaha changed the title Fatal if CLI gives negative result Make changes to run cli from the appscode/grafana-dashboards CI May 23, 2024
Copy link

gitguardian bot commented Jul 4, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8183097 Triggered Generic Password 91721c0 pkg/data/mysql.go View secret
8183097 Triggered Generic Password 91721c0 pkg/data/mariadb.go View secret
8183097 Triggered Generic Password 91721c0 pkg/data/mysql.go View secret
8183097 Triggered Generic Password 91721c0 pkg/data/mariadb.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Signed-off-by: sayedppqq <[email protected]>
Signed-off-by: sayedppqq <[email protected]>
Signed-off-by: sayedppqq <[email protected]>
Signed-off-by: Arnob kumar saha <[email protected]>
Signed-off-by: sayedppqq <[email protected]>
Signed-off-by: sayedppqq <[email protected]>
@ArnobKumarSaha ArnobKumarSaha merged commit a82c4b2 into master Jul 17, 2024
5 checks passed
@ArnobKumarSaha ArnobKumarSaha deleted the check branch July 17, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants