Fix panic when --use-proxy is true #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor of query logic caused o.restConfig to always be nil. This commit fixes that by simply passing through the restConfig in the proxy query case. Problem discovered by CI: https://github.com/kubecost/integration-ci-cd/actions/runs/4014159525/jobs/6906486306 Signed-off-by: Michael Dresser <[email protected]>
michaelmdresser
requested review from
saweber,
nikovacevic,
avrodrigues5 and
nickcurie
|
For context, this was probably introduced by #137 |
saweber
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Refactor of query logic caused o.restConfig to always be nil. This commit fixes that by simply passing through the restConfig in the proxy query case.
Problem discovered by CI: https://github.com/kubecost/integration-ci-cd/actions/runs/4014159525/jobs/6906486306
How does this PR impact users? (This is the kind of thing that goes in release notes!)
How was this PR tested?
Locally. Observed panic before change with
--use-proxyand no panic after.