Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyperlink in hardening guide #1752

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

SD-13
Copy link
Contributor

@SD-13 SD-13 commented May 14, 2024

Purpose of PR?:

Fixes wrong hyperlink in hardening guide doc.

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@SD-13
Copy link
Contributor Author

SD-13 commented May 14, 2024

@DelusionalOptimist PTAL. Thanks!

Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @SD-13!

@kranurag7
Copy link
Member

@SD-13 can you please rebase this PR to main branch.

@SD-13
Copy link
Contributor Author

SD-13 commented Jul 30, 2024

@kranurag7 done!

Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SD-13

@kranurag7 kranurag7 merged commit 6aecc1a into kubearmor:main Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants