use File.exist? because Ruby 3.2 does not have File.exists? #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockdeep
added a commit
to stringer-rss/stringer
that referenced
this pull request
Dec 31, 2022
It currently [doesn't work with Ruby 3.2][r3]. For our purposes, we can instead replace it with a small rake task. [r3]: ku1ik/racksh#15
mockdeep
added a commit
to stringer-rss/stringer
that referenced
this pull request
Jan 1, 2023
It currently [doesn't work with Ruby 3.2][r3]. For our purposes, we can instead replace it with a small rake task. [r3]: ku1ik/racksh#15
dentarg
added a commit
to spinels/racksh
that referenced
this pull request
Mar 10, 2023
Should have done this before merge of ku1ik#15 Oh well :)
|
I merged this PR over at https://github.com/spinels/racksh and published |
|
hi @sickill , why did the PR didn't get merged? it is a needed update for newer version of ruby and was raised back in 2022... I can help with the gem maintenance if needed |
|
Hey guys. Thanks for this. I don't use Ruby anymore and I don't have many opportunities to maintain this gem or review/test PRs. Let me try to publish this to rubygems right now 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.