kuring-168 캠퍼스맵 탭을 compose로 migrate #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kuring.atlassian.net/browse/KURING-168?atlOrigin=eyJpIjoiNWY0MTI0YmMzYjZmNGFlZWI3MGZkNDE5ZjI5YWEyODAiLCJwIjoiaiJ9
작업 내용
캠퍼스맵 탭을 compose로 구현하고, 더 이상 사용하지 않는 XML 및 fragment 코드를 제거했습니다.
이후 작업
메인 탭 4개의 navigation 선언캠퍼스맵 화면을 Compose로 migrateSettingScreen도 type-safe navigation으로 전환 (현재는 String 기반)사용하지 않는 XML 등 제거3번 작업은 내일까지 작업되면 내일 출시하고, 아니면 다음 출시로 넘기겠습니다.