Introduce CoroutineStackFrame and implement it in SuspendFunctionGun … #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reusable completion in order to properly walk through stackframes of interceptors
cy6erGn0m
reviewed
Dec 11, 2018
cy6erGn0m
reviewed
Dec 11, 2018
cy6erGn0m
reviewed
Dec 11, 2018
| private var index = 0 | ||
|
|
||
| override fun finish() { | ||
| index = blocks.size | ||
| } | ||
|
|
||
| override suspend fun proceed(): TSubject = suspendCoroutineUninterceptedOrReturn { continuation -> | ||
| proceedContinuation = continuation |
There was a problem hiding this comment.
proceed() could be invoked multiple times: this is why continuations are stacked in this case. Shouldn't proceedContinuation be restored back when leaving a proceed level?
…ke stack of the interceptor walkable once per rootContinuation state change in order to provide diagnostic in 99% of use-cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…reusable completion in order to properly walk through stackframes of interceptors