Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-5479 Improve log message about skipping response body transforma… #3379

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

Stexxe
Copy link
Contributor

@Stexxe Stexxe commented Jan 26, 2023

@Stexxe Stexxe requested a review from e5l January 26, 2023 10:32
@Stexxe Stexxe closed this Jan 26, 2023
@Stexxe Stexxe reopened this Jan 26, 2023
@@ -21,7 +22,13 @@ internal fun PluginBuilder<ContentNegotiationConfig>.convertResponseBody() = onC
}

if (pluginConfig.ignoredTypes.any { it.isInstance(subject) }) {
LOGGER.trace("Skipping because the type is ignored.")
val sourceClass = subject::class.simpleName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the client logger as well

Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Stexxe Stexxe merged commit aaea969 into main Jan 30, 2023
@Stexxe Stexxe deleted the stexxe/ignored-type-log-KTOR-5479 branch January 30, 2023 16:09
@Stexxe Stexxe restored the stexxe/ignored-type-log-KTOR-5479 branch January 30, 2023 16:09
@Stexxe Stexxe deleted the stexxe/ignored-type-log-KTOR-5479 branch January 30, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants