Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-4729 KTOR-4926 Disable auto reload in tests #3185

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

rsinukov
Copy link
Contributor

@rsinukov rsinukov commented Oct 5, 2022

Using empty watchPaths disables creating special class loader. In the future, we may add a new property to enable the development mode, but disable auto reload explicitly. But it needs design on how developmentMode, autoReload and watchPaths properties should work together

https://youtrack.jetbrains.com/issue/KTOR-4729
https://youtrack.jetbrains.com/issue/KTOR-4926

@rsinukov rsinukov requested a review from e5l October 5, 2022 23:00
@rsinukov rsinukov self-assigned this Oct 5, 2022
Using empty `watchPaths` disable creating special class loader. In the future, we may add a new property to enable the development mode, but disable auto reload explicitly. But it needs design on how `developmentMode`, `autoReload` and `watchPaths` properties should work together
@rsinukov rsinukov force-pushed the rsinukov/tests-development-mode branch from d916804 to 4eca76f Compare October 5, 2022 23:01
@rsinukov rsinukov changed the base branch from 2.2.0-eap to main October 5, 2022 23:02
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsinukov rsinukov merged commit 2516f0f into main Oct 6, 2022
@rsinukov rsinukov deleted the rsinukov/tests-development-mode branch October 6, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants