Change to the windows updater script to successfully complete and sta… #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, if the version number contains parenthesis ie "1.0 (3) _32 bits", the updater script fails when trying to start the updated app. This happens in the last If block:
The %APP_VERSION% variable is expanded before the code block is executed and the parenthesis make the entire block fail.
Adding
setlocal enabledelayedexpansion
and refering to the variable with!APP_VERSION!
enables the variable to be expanded only when the specific line is executed, and not then the block code is evaluated, thus solving the problem.