Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no way to supply single files as assets #8

Closed
igalic opened this issue Jan 28, 2018 · 2 comments
Closed

no way to supply single files as assets #8

igalic opened this issue Jan 28, 2018 · 2 comments

Comments

@igalic
Copy link

igalic commented Jan 28, 2018

I'd like to supply a single file as asset, such as a favicion.ico, however, the asset array assumes all elements are directories.

Is there any way to fix that?
because even if i "manually" copy the file in a script line:

{
  "dependencies": {
    "remarker": "^1.6.2"
  },
  "scripts": {
    "build": "remarker build; cp favicon.ico build/",
    "serve": "remarker serve",
    "clean": "rm -rf build"
  }
}

it won't work, because the assets array is also used to build what's being served.

kt3k added a commit that referenced this issue Jan 29, 2018
@kt3k
Copy link
Owner

kt3k commented Jan 29, 2018

I added type check for assets entries and release it as v1.7.1. I think it solves your problem. Please check the latest version.

An example for favicon use case is available at https://github.com/kt3k/remarker/tree/master/examples/favicon

@igalic
Copy link
Author

igalic commented Jan 29, 2018

perfect! thank you so much!

@igalic igalic closed this as completed Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants