Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization of remark.js #4

Closed
wookayin opened this issue Nov 24, 2017 · 3 comments
Closed

Customization of remark.js #4

wookayin opened this issue Nov 24, 2017 · 3 comments

Comments

@wookayin
Copy link

wookayin commented Nov 24, 2017

Can we configure so that we can use another version of remark.js? Currently, I think it is hard-coded and bundled together (vendor/remark.js). It would be great to allow customization of scripts, not only specifying the version or path to remark.js, but also injecting custom javascript code (like css).

One another problem is that is not a minified version; viewing source is quite annoying. Moreover, I think it'd better to load remark.js as an external resource (e.g. script src) by default.

@kt3k
Copy link
Owner

kt3k commented Nov 26, 2017

Thanks for the feedback!

Currently, I think it is hard-coded and bundled together (vendor/remark.js).

Yes, that's hard coded now.

It would be great to allow customization of scripts, not only specifying the version or path to remark.js, but also injecting custom javascript code (like css).

I agree that injecting scripts could be useful in some use cases. I'll work on it soon.

One another problem is that is not a minified version; viewing source is quite annoying. Moreover, I think it'd better to load remark.js as an external resource (e.g. script src) by default.

OK. I see that if soneone try to hack on the remarker output html, the current bundle is not comfortable to work on. I'll try to make the script external.

Thanks for trying remarker!

kt3k added a commit that referenced this issue Nov 28, 2017
@kt3k
Copy link
Owner

kt3k commented Nov 28, 2017

@wookayin
I added script option ( refs: 751f707 ) and remark.js path configurable ( refs: 73a3957 ).

Could you check the behavior when you have time?

@wookayin
Copy link
Author

Great! They work well. Thanks for the support :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants