-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update huggingface readme #3678
Merged
yuzisun
merged 8 commits into
kserve:master
from
alexagriffith:update-huggingface-readme
May 11, 2024
Merged
Update huggingface readme #3678
yuzisun
merged 8 commits into
kserve:master
from
alexagriffith:update-huggingface-readme
May 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small update to make readme easier to understand Signed-off-by: Alexa Griffith <[email protected]>
Signed-off-by: Alexa Griffith [email protected]
Co-authored-by: Filippe Spolti <[email protected]> Signed-off-by: Alexa Griffith <[email protected]>
6eba22c
to
4a22f6c
Compare
Signed-off-by: alexagriffith <[email protected]>
Signed-off-by: alexagriffith <[email protected]>
Signed-off-by: alexagriffith <[email protected]>
houshengbo
reviewed
May 10, 2024
houshengbo
reviewed
May 10, 2024
houshengbo
reviewed
May 10, 2024
houshengbo
reviewed
May 10, 2024
Signed-off-by: Dan Sun <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexagriffith, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
asd981256
pushed a commit
to asd981256/kserve
that referenced
this pull request
May 14, 2024
* update wording for huggingface README small update to make readme easier to understand Signed-off-by: Alexa Griffith <[email protected]> * Update README.md Signed-off-by: Alexa Griffith [email protected] * Update python/huggingfaceserver/README.md Co-authored-by: Filippe Spolti <[email protected]> Signed-off-by: Alexa Griffith <[email protected]> * update vllm Signed-off-by: alexagriffith <[email protected]> * Update README.md --------- Signed-off-by: Alexa Griffith <[email protected]> Signed-off-by: Alexa Griffith [email protected] Signed-off-by: alexagriffith <[email protected]> Signed-off-by: Dan Sun <[email protected]> Co-authored-by: Filippe Spolti <[email protected]> Co-authored-by: Dan Sun <[email protected]> Signed-off-by: asd981256 <[email protected]>
oss-prow-bot bot
pushed a commit
that referenced
this pull request
May 18, 2024
* upgrade vllm/transformers version (#3671) upgrade vllm version Signed-off-by: Johnu George <[email protected]> * Add openai models endpoint (#3666) Signed-off-by: Curtis Maddalozzo <[email protected]> * feat: Support customizable deployment strategy for RawDeployment mode. Fixes #3452 (#3603) * feat: Support customizable deployment strategy for RawDeployment mode Signed-off-by: Yuan Tang <[email protected]> * regen Signed-off-by: Yuan Tang <[email protected]> * lint Signed-off-by: Yuan Tang <[email protected]> * Correctly apply rollingupdate Signed-off-by: Yuan Tang <[email protected]> * address comments Signed-off-by: Yuan Tang <[email protected]> * Add validation Signed-off-by: Yuan Tang <[email protected]> --------- Signed-off-by: Yuan Tang <[email protected]> * Enable dtype support for huggingface server (#3613) * Enable dtype for huggingface server Signed-off-by: Dattu Sharma <[email protected]> * Set float16 as default. Fixup linter Signed-off-by: Dattu Sharma <[email protected]> * Add small comment to make the changes understandable Signed-off-by: Dattu Sharma <[email protected]> * Fixup linter Signed-off-by: Dattu Sharma <[email protected]> * Adapt to new huggingfacemodel Signed-off-by: Dattu Sharma <[email protected]> * Fixup merge :) Signed-off-by: Dattu Sharma <[email protected]> * Explicitly mention the behaviour of dtype flag on auto. Signed-off-by: Dattu Sharma <[email protected]> * Default to FP32 for encoder models Signed-off-by: Dattu Sharma <[email protected]> * Selectively add --dtype to parser. Use FP16 for GPU and FP32 for CPU Signed-off-by: Dattu Sharma <[email protected]> * Fixup linter Signed-off-by: Dattu Sharma <[email protected]> * Update poetry Signed-off-by: Dattu Sharma <[email protected]> * Use torch.float32 forr tests explicitly Signed-off-by: Dattu Sharma <[email protected]> --------- Signed-off-by: Dattu Sharma <[email protected]> * Add method for checking model health/readiness (#3673) Signed-off-by: Curtis Maddalozzo <[email protected]> * fix for extract zip from gcs (#3510) * fix for extract zip from gcs Signed-off-by: Andrews Arokiam <[email protected]> * initial commit for gcs model download unittests Signed-off-by: Andrews Arokiam <[email protected]> * unittests for model download from gcs Signed-off-by: Andrews Arokiam <[email protected]> * black format fix Signed-off-by: Andrews Arokiam <[email protected]> * code verification Signed-off-by: Andrews Arokiam <[email protected]> --------- Signed-off-by: Andrews Arokiam <[email protected]> * Update Dockerfile and Readme (#3676) Signed-off-by: Gavrish Prabhu <[email protected]> * Update huggingface readme (#3678) * update wording for huggingface README small update to make readme easier to understand Signed-off-by: Alexa Griffith <[email protected]> * Update README.md Signed-off-by: Alexa Griffith [email protected] * Update python/huggingfaceserver/README.md Co-authored-by: Filippe Spolti <[email protected]> Signed-off-by: Alexa Griffith <[email protected]> * update vllm Signed-off-by: alexagriffith <[email protected]> * Update README.md --------- Signed-off-by: Alexa Griffith <[email protected]> Signed-off-by: Alexa Griffith [email protected] Signed-off-by: alexagriffith <[email protected]> Signed-off-by: Dan Sun <[email protected]> Co-authored-by: Filippe Spolti <[email protected]> Co-authored-by: Dan Sun <[email protected]> * fix: HPA equality check should include annotations (#3650) * fix: HPA equality check should include annotations Signed-off-by: Yuan Tang <[email protected]> * Only watch related autoscalerclass annotation Signed-off-by: Yuan Tang <[email protected]> * simplify Signed-off-by: Yuan Tang <[email protected]> * Add missing delete action Signed-off-by: Yuan Tang <[email protected]> * fix logic Signed-off-by: Yuan Tang <[email protected]> --------- Signed-off-by: Yuan Tang <[email protected]> * Fix: huggingface runtime in helm chart (#3679) fix huggingface runtime in chart Signed-off-by: Dan Sun <[email protected]> * Fix: model id and model dir check order (#3680) * fix huggingface runtime in chart Signed-off-by: Dan Sun <[email protected]> * Allow model_dir to be specified on template Signed-off-by: Dan Sun <[email protected]> * Default model_dir to /mnt/models for HF Signed-off-by: Dan Sun <[email protected]> * Lint format Signed-off-by: Dan Sun <[email protected]> --------- Signed-off-by: Dan Sun <[email protected]> * Fix:vLLM Model Supported check throwing circular dependency (#3688) * Fix:vLLM Model Supported check throwing circular dependency Signed-off-by: Gavrish Prabhu <[email protected]> * remove unwanted comments Signed-off-by: Gavrish Prabhu <[email protected]> * remove unwanted comments Signed-off-by: Gavrish Prabhu <[email protected]> * fix return case Signed-off-by: Gavrish Prabhu <[email protected]> * fix to check all arch in model config forr vllm support Signed-off-by: Gavrish Prabhu <[email protected]> * fixlint Signed-off-by: Gavrish Prabhu <[email protected]> --------- Signed-off-by: Gavrish Prabhu <[email protected]> * Fix: Allow null in Finish reason streaming response in vLLM (#3684) Fix: allow null in Finish reason Signed-off-by: Gavrish Prabhu <[email protected]> --------- Signed-off-by: Johnu George <[email protected]> Signed-off-by: Curtis Maddalozzo <[email protected]> Signed-off-by: Yuan Tang <[email protected]> Signed-off-by: Dattu Sharma <[email protected]> Signed-off-by: Andrews Arokiam <[email protected]> Signed-off-by: Gavrish Prabhu <[email protected]> Signed-off-by: Alexa Griffith <[email protected]> Signed-off-by: Alexa Griffith [email protected] Signed-off-by: alexagriffith <[email protected]> Signed-off-by: Dan Sun <[email protected]> Co-authored-by: Curtis Maddalozzo <[email protected]> Co-authored-by: Yuan Tang <[email protected]> Co-authored-by: Datta Nimmaturi <[email protected]> Co-authored-by: Andrews Arokiam <[email protected]> Co-authored-by: Gavrish Prabhu <[email protected]> Co-authored-by: Alexa Griffith <[email protected]> Co-authored-by: Filippe Spolti <[email protected]> Co-authored-by: Dan Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.