Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProjectFiles to support xcframeworks #299

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

williamrexhardin
Copy link
Contributor

Adding support for Apple-native xcframework file types

@williamrexhardin
Copy link
Contributor Author

williamrexhardin commented Feb 5, 2021

Looks like the checks are failing for an unrelated reason:

coveralls.exception.CoverallsException: Running on Github Actions but GITHUB_TOKEN is not set. Add "env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}" to your step config.

@kronenthaler
Copy link
Owner

kronenthaler commented Feb 5, 2021

Looks like the checks are failing for an unrelated reason:

coveralls.exception.CoverallsException: Running on Github Actions but GITHUB_TOKEN is not set. Add "env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}" to your step config.

Yes, i have addressed in the master branch now. Could you rebase to master or push again?

@kronenthaler
Copy link
Owner

Thanks for your contribution.

All looking good. One last request, could you add a small unit test for it?

@williamrexhardin
Copy link
Contributor Author

@kronenthaler I have pulled from master, added a unit test and pushed updates the PR, looks like the checks worked for 3.6 but not the other versions.

@kronenthaler kronenthaler merged commit 5e87b76 into kronenthaler:master Feb 5, 2021
@williamrexhardin
Copy link
Contributor Author

@kronenthaler is it possible to release a 3.2.1 patch version with these changes? I am actively working on a project that needs to consume these itty bitty details. Thank you!

@kronenthaler
Copy link
Owner

Release on its way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants