Skip to content

Commit

Permalink
Changes for making the file RTL compatible (oppia#3847)
Browse files Browse the repository at this point in the history
* Changes for making the file RTL compatible

* removed profile activity xml from exempted file list

* removed empty git file
  • Loading branch information
bkaur-bkj committed Sep 29, 2021
1 parent 7ff1b2b commit e631ffe
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions app/src/main/res/layout/add_profile_activity.xml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@
android:paddingTop="12dp"
android:src="@drawable/rounded_white_background_with_shadow"
app:layout_constraintBottom_toBottomOf="@+id/add_profile_activity_user_image_view"
app:layout_constraintEnd_toEndOf="@+id/add_profile_activity_user_image_view"
app:layout_constraintRight_toRightOf="@+id/add_profile_activity_user_image_view" />
app:layout_constraintEnd_toEndOf="@+id/add_profile_activity_user_image_view" />

<TextView
android:id="@+id/add_profile_activity_required_heading_text_view"
Expand Down
1 change: 0 additions & 1 deletion scripts/assets/file_content_validation_checks.textproto
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ file_content_checks {
file_path_regex: ".+?.xml"
prohibited_content_regex: "paddingLeft|paddingRight|drawableLeft|drawableRight|layout_alignLeft|layout_alignRight|layout_marginLeft|layout_marginRight|layout_alignParentLeft|layout_alignParentRight|layout_toLeftOf|layout_toRightOf|layout_constraintLeft_toLeftOf|layout_constraintLeft_toRightOf|layout_constraintRight_toLeftOf|layout_constraintRight_toRightOf|layout_goneMarginLeft|layout_goneMarginRight"
failure_message: "Use start/end versions of layout properties, instead, for proper RTL support"
exempted_file_name: "app/src/main/res/layout/add_profile_activity.xml"
exempted_file_name: "app/src/main/res/layout/profile_progress_header.xml"
exempted_file_name: "app/src/main/res/layout-land/profile_progress_header.xml"
exempted_file_name: "app/src/main/res/layout-sw600dp-land/profile_progress_header.xml"
Expand Down

0 comments on commit e631ffe

Please sign in to comment.