Skip to content

Commit

Permalink
Fix oppia#3532: Deleted help_activity.xml (land) file (oppia#3597)
Browse files Browse the repository at this point in the history
* Deleted help_activity.xml (land) file

* Added navigation_drawer_width in dimens file as 304dp and replaced layout_width with it

* Changed comment in dimens.xml from Help to NavigationDrawer
  • Loading branch information
UttaranDas committed Aug 16, 2021
1 parent 54e79d0 commit 2f4cd1d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 44 deletions.
43 changes: 0 additions & 43 deletions app/src/main/res/layout-land/help_activity.xml

This file was deleted.

2 changes: 1 addition & 1 deletion app/src/main/res/layout/help_activity.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<fragment
android:id="@+id/help_activity_fragment_navigation_drawer"
android:name="org.oppia.android.app.drawer.NavigationDrawerFragment"
android:layout_width="match_parent"
android:layout_width="@dimen/navigation_drawer_width"
android:layout_height="match_parent"
android:layout_gravity="start"
app:layout="@layout/drawer_fragment"
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/res/values/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,9 @@
<dimen name="faq_item_header_margin_end">24dp</dimen>
<dimen name="faq_item_header_margin_bottom">8dp</dimen>

<!-- NavigationDrawer -->
<dimen name="navigation_drawer_width">304dp</dimen>

<!-- General Bottom Padding -->
<dimen name="general_screen_padding_bottom">128dp</dimen>

Expand Down

0 comments on commit 2f4cd1d

Please sign in to comment.