fix: wasm addFunction tests #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does |
|
I like the idea of enabling this by default, it seems popular... I can go ahead and tweak |
|
All set... 👍👍 |
Fixes concurrency issues when testing wasm ammo
ianpurvis
force-pushed
the
fix/wasm-add-function-tests
branch
from
aba58bb
to
df91273
Compare
|
Sorry, things got messy when I merged #331... this should be good to go now. |
kripken
reviewed
Aug 26, 2020
kripken
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes breakage in emsdk 2.0 and starts building and testing addFunction during CI.