Skip to content

Commit

Permalink
Revert "[CI] Fix shellcheck lint (ray-project#34488)" (ray-project#34529
Browse files Browse the repository at this point in the history
)

The shellcheck fix broke the shellscript when $use_lstm is empty

Signed-off-by: Kai Fricke <[email protected]>
  • Loading branch information
krfricke committed Apr 18, 2023
1 parent d571fa2 commit 6843408
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rllib/env/tests/test_policy_client_server_setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ fi
# Start server with 2 workers (will listen on ports worker_1_port and worker_2_port for client
# connections).
# Do not attempt to restore from checkpoint; leads to errors on travis.
(python $basedir/$server_script --run="$trainer_cls" --num-workers=2 "$use_lstm" --no-restore --port=$worker_1_port 2>&1 | grep -v 200) &
# shellcheck disable=SC2086
(python $basedir/$server_script --run="$trainer_cls" --num-workers=2 $use_lstm --no-restore --port=$worker_1_port 2>&1 | grep -v 200) &
server_pid=$!

echo "Waiting for server to start ..."
Expand Down

0 comments on commit 6843408

Please sign in to comment.