Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dedicated message type for MIDI Show Control messages #67

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add dedicated message type for MIDI Show Control messages #67

wants to merge 5 commits into from

Commits on May 5, 2020

  1. Introduce the SMShowControlMessage

    @spark404
    spark404 committed May 5, 2020
    Configuration menu
    Copy the full SHA
    ee7a77a View commit details
    Browse the repository at this point in the history

  2. Move parsers to a utility file and complete the parameter parsing for… 

    … most common shocwontrol messages
    @spark404
    spark404 committed May 5, 2020
    Configuration menu
    Copy the full SHA
    9aa9423 View commit details
    Browse the repository at this point in the history

  3. Refactor cue item parser to not depend on the 0xF7 marker

    @spark404
    spark404 committed May 5, 2020
    Configuration menu
    Copy the full SHA
    9bb0fef View commit details
    Browse the repository at this point in the history

  4. WIP, untested: integrate more into SnoizeMIDI. 

    - Don't use a separate show control message type, just put it all in sysex message
- Cache dataForDisplay in sysex messages
- rename some stuff
- fix leak in parseCueItemsData

TODO:
- In tests target, use config files instead of ad-hoc settings
- test failing in parseCueItemsData, clean that up probably
- check this with MIDI Show Control spec, I suspect there is a lot more to show
- new TODOs in sysex message, e.g. checking for message lengths
    @krevis @spark404
    krevis authored and spark404 committed May 5, 2020
    Configuration menu
    Copy the full SHA
    a2c93a3 View commit details
    Browse the repository at this point in the history

  5. Fix testParseCueListWithoutEntries, simplify parseCueItemsData

    @krevis @spark404
    krevis authored and spark404 committed May 5, 2020
    Configuration menu
    Copy the full SHA
    63d2345 View commit details
    Browse the repository at this point in the history