Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement more Shampoo features #99

Merged
merged 55 commits into from
Jan 31, 2023
Merged

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Jan 31, 2023

Problem (Why?)

the original JAX implementation has more features.

Solution (What/How?)

  • implement moving_average_for_momentum
  • implement decoupled_weight_decay
  • implement decoupled_learning_rate
  • implement more grafting types
    • RMSProp
    • SQRT_N
  • implement type of preconditioner
    • ALL
    • INPUT (one-sided Shampoo)

Other changes (bug fixes, small refactors)

nope

Notes

  • still there's a limitation on distributed training.
  • bump version to v2.3.1

@kozistr kozistr added the feature New features label Jan 31, 2023
@kozistr kozistr self-assigned this Jan 31, 2023
@kozistr kozistr changed the title [Feature] Implement more Shampoo options [Feature] Implement more Shampoo features Jan 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #99 (5da4074) into main (40f34df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   99.64%   99.65%           
=======================================
  Files          37       37           
  Lines        2568     2618   +50     
=======================================
+ Hits         2559     2609   +50     
  Misses          9        9           
Impacted Files Coverage Δ
pytorch_optimizer/optimizer/shampoo.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/shampoo_utils.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/utils.py 97.75% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 31, 2023
@kozistr kozistr merged commit 44c423a into main Jan 31, 2023
@kozistr kozistr deleted the update/shampoo-optimizer branch January 31, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants