Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Cleanup the codes #96

Merged
merged 25 commits into from
Jan 29, 2023
Merged

[Refactor] Cleanup the codes #96

merged 25 commits into from
Jan 29, 2023

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Jan 29, 2023

Problem (Why?)

refactor the codes

Solution (What/How?)

  • change to in-place operations
  • remove casting to fp16 or bf16

Other changes (bug fixes, small refactors)

  • fix exp_avg_var when amsgrad is True.

Notes

nope

@kozistr kozistr added the refactoring Refactoring label Jan 29, 2023
@kozistr kozistr self-assigned this Jan 29, 2023
@kozistr kozistr changed the title [Refactor] codes [Refactor] cleanup codes Jan 29, 2023
@kozistr kozistr changed the title [Refactor] cleanup codes [Refactor] Cleanup the codes Jan 29, 2023
@kozistr kozistr added the bug Something isn't working label Jan 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Merging #96 (c155279) into main (ce56167) will increase coverage by 0.07%.
The diff coverage is 99.09%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   97.76%   97.84%   +0.07%     
==========================================
  Files          37       37              
  Lines        2551     2502      -49     
==========================================
- Hits         2494     2448      -46     
+ Misses         57       54       -3     
Impacted Files Coverage Δ
pytorch_optimizer/optimizer/ranger21.py 98.88% <75.00%> (-0.02%) ⬇️
pytorch_optimizer/optimizer/adabelief.py 100.00% <100.00%> (+2.70%) ⬆️
pytorch_optimizer/optimizer/adabound.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adamp.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adan.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adapnm.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/diffgrad.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/diffrgrad.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/lars.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/madgrad.py 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kozistr kozistr merged commit 0567ae9 into main Jan 29, 2023
@kozistr kozistr deleted the refactor/optimizers branch January 29, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring Refactoring size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants