Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add test cases for utils #49

Merged
merged 7 commits into from
Jan 31, 2022
Merged

[Test] Add test cases for utils #49

merged 7 commits into from
Jan 31, 2022

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Jan 31, 2022

Problem (Why?)

Need test cases for utils

Solution (What/How?)

  • has_overflow
  • normalize_gradient
  • clip_grad_norm
  • unit_norm
  • get_optimizer_parameters

Other changes (bug fixes, small refactors)

nope

Notes

nope

@kozistr kozistr added refactoring Refactoring feature New features labels Jan 31, 2022
@kozistr kozistr self-assigned this Jan 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #49 (fa6d4b1) into main (2162e68) will increase coverage by 1.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   85.89%   86.93%   +1.04%     
==========================================
  Files          25       25              
  Lines        1737     1738       +1     
==========================================
+ Hits         1492     1511      +19     
+ Misses        245      227      -18     
Impacted Files Coverage Δ
pytorch_optimizer/version.py 0.00% <0.00%> (ø)
pytorch_optimizer/utils.py 91.83% <100.00%> (+37.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2162e68...fa6d4b1. Read the comment docs.

@kozistr kozistr merged commit 16aeb2c into main Jan 31, 2022
@kozistr kozistr deleted the test/utils branch January 31, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants