Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect recursive initialization in configurable module #48

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

fvasco
Copy link

@fvasco fvasco commented Feb 22, 2017

Detect StackOverflowError in the following case:
(Note Kodein.global reference in constructor and eagerSingleton)

class Loop(text: String = Kodein.global.instance())

val module = Kodein.Module {
    bind<String>() with singleton { "test" }
    bind<Loop>() with eagerSingleton { Loop() }
}

fun main(vararg args: String) {
    Kodein.global.addImport(module)
    Kodein.global.instance<Loop>()
}


Exception in thread "main" java.lang.StackOverflowError
    at TestKt$module$1.invoke(Test.kt)
    at TestKt$module$1.invoke(Test.kt)
    at com.github.salomonbrys.kodein.Kodein$Builder.<init>(Kodein.kt:303)
    at com.github.salomonbrys.kodein.Kodein$Builder.import(Kodein.kt:387)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein$addImport$1.invoke(ConfigurableKodein.kt:144)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein$addImport$1.invoke(ConfigurableKodein.kt:14)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein$getOrConstruct$$inlined$synchronized$lambda$1.invoke(ConfigurableKodein.kt:79)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein$getOrConstruct$$inlined$synchronized$lambda$1.invoke(ConfigurableKodein.kt:14)
    at com.github.salomonbrys.kodein.Kodein$Builder.<init>(Kodein.kt:303)
    at com.github.salomonbrys.kodein.internal.KodeinImpl.<init>(KodeinImpl.kt:34)
    at com.github.salomonbrys.kodein.Kodein$Companion.invoke(Kodein.kt:469)
    at com.github.salomonbrys.kodein.Kodein$Companion.invoke$default(Kodein.kt:469)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein.getOrConstruct(ConfigurableKodein.kt:77)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein.getTyped(ConfigurableKodein.kt:156)
    at Loop.<init>(Test.kt:20)
    at TestKt$module$1$2.invoke(Test.kt:8)
    at TestKt$module$1$2.invoke(Test.kt)
    at com.github.salomonbrys.kodein.ASingleton.getInstance(factories.kt:108)
    at com.github.salomonbrys.kodein.CEagerSingleton$1.invoke(factories.kt:159)
    at com.github.salomonbrys.kodein.CEagerSingleton$1.invoke(factories.kt:156)
    at com.github.salomonbrys.kodein.Kodein$Builder$onProviderReady$1.invoke(Kodein.kt:433)
    at com.github.salomonbrys.kodein.Kodein$Builder$onProviderReady$1.invoke(Kodein.kt:163)
    at com.github.salomonbrys.kodein.internal.KodeinImpl.<init>(KodeinImpl.kt:28)
    at com.github.salomonbrys.kodein.internal.KodeinImpl.<init>(KodeinImpl.kt:34)
    at com.github.salomonbrys.kodein.Kodein$Companion.invoke(Kodein.kt:469)
    at com.github.salomonbrys.kodein.Kodein$Companion.invoke$default(Kodein.kt:469)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein.getOrConstruct(ConfigurableKodein.kt:77)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein.getTyped(ConfigurableKodein.kt:156)
    at Loop.<init>(Test.kt:20)
    at TestKt$module$1$2.invoke(Test.kt:8)
    at TestKt$module$1$2.invoke(Test.kt)
    at com.github.salomonbrys.kodein.ASingleton.getInstance(factories.kt:108)
    at com.github.salomonbrys.kodein.CEagerSingleton$1.invoke(factories.kt:159)
    at com.github.salomonbrys.kodein.CEagerSingleton$1.invoke(factories.kt:156)
    at com.github.salomonbrys.kodein.Kodein$Builder$onProviderReady$1.invoke(Kodein.kt:433)
    at com.github.salomonbrys.kodein.Kodein$Builder$onProviderReady$1.invoke(Kodein.kt:163)
    at com.github.salomonbrys.kodein.internal.KodeinImpl.<init>(KodeinImpl.kt:28)
    at com.github.salomonbrys.kodein.internal.KodeinImpl.<init>(KodeinImpl.kt:34)
    at com.github.salomonbrys.kodein.Kodein$Companion.invoke(Kodein.kt:469)
    at com.github.salomonbrys.kodein.Kodein$Companion.invoke$default(Kodein.kt:469)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein.getOrConstruct(ConfigurableKodein.kt:77)
    at com.github.salomonbrys.kodein.conf.ConfigurableKodein.getTyped(ConfigurableKodein.kt:156)
    at Loop.<init>(Test.kt:20)
    at TestKt$module$1$2.invoke(Test.kt:8)
    at TestKt$module$1$2.invoke(Test.kt)

@SalomonBrys
Copy link
Member

Wow. Thanks a lot for this...
Great fix !

@SalomonBrys SalomonBrys merged commit 4eaf346 into kosi-libs:master Mar 2, 2017
@SalomonBrys
Copy link
Member

This usecase should not throw an exception anymore. Commit 7c6240b fixes KodeinGlobal and allow these kind of recursive initialisation dependencies :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants