fix/update failed E2E tests (mattermost#7430)

koox00 · Feb 2, 2021 · bfe4909 · bfe4909
1 parent 6f644c3
commit bfe4909
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 13 deletions.
diff --git a/e2e/cypress/integration/account_settings/general/email_spec.js b/e2e/cypress/integration/account_settings/general/email_spec.js
@@ -118,8 +118,9 @@ describe('Account Settings -> General -> Email', () => {
  cy.get('#confirmEmail').should('be.visible').type(`user-${randomId}@example.com`);
  cy.get('#currentPassword').should('be.visible').type(testUser.password);
 
- // # Save the settings
+ // # Save the settings and close
  cy.get('#saveSetting').click().wait(TIMEOUTS.HALF_SEC);
+ cy.uiClose();
 
  // * Verify the announcement bar
  cy.get('.announcement-bar').should('be.visible').should('contain.text', 'Check your email inbox to verify the address.');

diff --git a/e2e/cypress/integration/enterprise/system_console/sidebar_link_navigation_spec.js b/e2e/cypress/integration/enterprise/system_console/sidebar_link_navigation_spec.js
@@ -55,9 +55,9 @@ describe('System Console - Enterprise', () => {
  url: 'admin_console/authentication/saml',
  },
  {
- header: 'OAuth 2.0',
- sidebar: 'OAuth 2.0',
- url: 'admin_console/authentication/oauth',
+ header: 'OpenID Connect',
+ sidebar: 'OpenID Connect',
+ url: 'admin_console/authentication/openid',
  },
  {
  header: 'Guest Access (Beta)',

diff --git a/...ss/integration/enterprise/visual_regression/system_console/authentication_section_spec.js b/...ss/integration/enterprise/visual_regression/system_console/authentication_section_spec.js
@@ -60,9 +60,9 @@ describe('System Console - Authentication', () => {
  },
  {
  section: 'Authentication',
- header: 'OAuth 2.0',
- sidebar: 'OAuth 2.0',
- url: 'admin_console/authentication/oauth',
+ header: 'OpenID Connect',
+ sidebar: 'OpenID Connect',
+ url: 'admin_console/authentication/openid',
  },
  {
  section: 'Authentication',

diff --git a/e2e/cypress/integration/search/clear_input_spec.js b/e2e/cypress/integration/search/clear_input_spec.js
@@ -22,9 +22,6 @@ describe('Search', () => {
  });
 
  it('QuickInput clear X', () => {
- // # Wait for the page to be completely loaded
- cy.wait(TIMEOUTS.FIVE_SEC);
-
  // * X should not be visible on empty input
  cy.get('#searchFormContainer').find('.input-clear-x').should('not.be.visible');
 
@@ -56,9 +53,7 @@ describe('Search', () => {
  cy.get('@searchInput').click().wait(TIMEOUTS.HALF_SEC).type(searchText);
 
  // # Click on the pinned post button from the header
- cy.get('#channel-header').within(() => {
- cy.findByLabelText('Pin Icon').should('be.visible').and('exist').click();
- });
+ cy.findByRole('button', {name: 'Pinned posts'}).should('be.visible').click();
 
  // * Verify the pinned post RHS is open
  cy.get('#sidebar-right').should('be.visible').and('contain', 'Pinned Posts');