-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance testing #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mciszczon
force-pushed
the
master
branch
3 times, most recently
from
December 22, 2022 15:03
9d22246
to
c22729f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a basic set of performance tests (achieved with
pytest-benchmark
), as well as a Github Actions integration to make it easier to work with the performance testing, as well as control any unwanted degradation of the performance.Implemented changes
pre-commit
hook configuration, to automatically runblack
on commit.pytest-benchmark
library to handle benchmarking.tests/performance/*
directory, which contains all the performance tests, related dataclasses and fixtures.pytest
to run performance tests and ensure valid output.benchmark-action/github-action-benchmark@v1
Github Action that runs performance tests, adds comments with the results and can even fail a CI run if the performance has significantly worsened.https://konradhalas.github.io/dacite/performance/X.Y
, whereX.Y
is the related Python version from Github Actions matrix (e.g.3.11
).Suggested actions
Before accepting and merging this PR, it is recommended to:
gh-pages
branch inkonradhalas/dacite
repo.GITHUB_TOKEN
key. The token must have the following permissions:konradhalas/dacite
repo.