Skip to content

Commit

Permalink
[FLINK-3129] Bring infrastructure for ensuring interface stability in…
Browse files Browse the repository at this point in the history
… place

This closes apache#2042
  • Loading branch information
rmetzger committed May 27, 2016
1 parent cbc5f83 commit 6c07936
Show file tree
Hide file tree
Showing 10 changed files with 142 additions and 2 deletions.
11 changes: 11 additions & 0 deletions flink-annotations/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,15 @@ under the License.

<packaging>jar</packaging>

<build>
<plugins>
<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>
</project>
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ public class ExecutionConfig implements Serializable {

private static final long DEFAULT_RESTART_DELAY = 10000L;

// This field was used as a key for storing the EC in the Job Configuration
@Deprecated
public static final String CONFIG_KEY = "runtime.config";

// --------------------------------------------------------------------------------------------

/** Defines how data exchange happens - batch or pipelined */
Expand Down
8 changes: 7 additions & 1 deletion flink-dist/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,13 @@ under the License.

<build>
<plugins>
<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<!--Build uber jar-->
<groupId>org.apache.maven.plugins</groupId>
Expand Down Expand Up @@ -272,7 +279,6 @@ under the License.
</links>
</configuration>
</plugin>

</plugins>
</build>
</project>
7 changes: 7 additions & 0 deletions flink-java8/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@ under the License.
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>

<pluginManagement>
Expand Down
8 changes: 8 additions & 0 deletions flink-quickstart/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ under the License.
</execution>
</executions>
</plugin>

<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>
</project>
13 changes: 13 additions & 0 deletions flink-shaded-curator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,17 @@
<name>flink-shaded-curator</name>

<packaging>pom</packaging>

<build>
<plugins>
<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

</project>
9 changes: 9 additions & 0 deletions flink-shaded-hadoop/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,15 @@ under the License.
</execution>
</executions>
</plugin>

<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>

</plugins>
</build>

Expand Down
22 changes: 22 additions & 0 deletions flink-streaming-scala/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,28 @@ under the License.
</configuration>
</plugin>

<!-- Exclude generated classes from api compatibilty checks -->
<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<version>0.7.0</version>
<configuration>
<parameter>
<excludes>
<exclude>*\$\$anon\$*</exclude>
</excludes>
</parameter>
</configuration>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>cmp</goal>
</goals>
</execution>
</executions>
</plugin>

<!-- Generate the test-jar -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
8 changes: 7 additions & 1 deletion flink-yarn-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,13 @@ under the License.
</execution>
</executions>
</plugin>

<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>
</project>
54 changes: 54 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -745,6 +745,60 @@ under the License.
<build>
<plugins>

<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<version>0.7.0</version>
<configuration>
<oldVersion>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>${project.artifactId}</artifactId>
<version>1.0.0</version>
<type>${project.packaging}</type>
</dependency>
</oldVersion>
<newVersion>
<file>
<path>${project.build.directory}/${project.artifactId}-${project.version}.${project.packaging}</path>
</file>
</newVersion>
<parameter>
<onlyModified>true</onlyModified>
<includes>
<include>@org.apache.flink.annotation.Public</include>
</includes>
<excludes>
<exclude>@org.apache.flink.annotation.PublicEvolving</exclude>
<exclude>@org.apache.flink.annotation.Internal</exclude>
</excludes>
<accessModifier>public</accessModifier>
<breakBuildOnModifications>false</breakBuildOnModifications>
<breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
<onlyBinaryIncompatible>false</onlyBinaryIncompatible>
<includeSynthetic>true</includeSynthetic>
<ignoreMissingClasses>false</ignoreMissingClasses>
<skipPomModules>true</skipPomModules>
</parameter>
<skip>false</skip>
<dependencies>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-annotations</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
</configuration>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>cmp</goal>
</goals>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
Expand Down

0 comments on commit 6c07936

Please sign in to comment.