Filtering of extra tags #594
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update PR? We need to your feature to query by extra tags because we has add some tags to extra-tag and want to search by it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for filtering of extra tags, related to #592.
So far it only enables filtering on the existence of keys inside the extra-tag object. Extra tags has been introduced via #576.
Example: http:https://localhost:2322/api?q=monaco&extra_key=wikidata&extra_key=wikipedia
Will only return elements with
wikidataorwikipediatags in extra. Behavior is similar toosm_key.ToDo:
wikipediaandwikidatagets indexed in elastic, because I don't know how to make it dynamic for all properties insideextra. If the mapping has to get done explicitly, all the extra tags can be found here: https://taginfo.openstreetmap.org/projects/nominatim#tags