This repository has been archived by the owner on May 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
If a port is already bound, script should abort #15
Labels
Comments
We defaulted the kolide from port 8080 to 8124 here for this exact reason. too many things use port 8080 Any thoughts on having it use a different port in addition to aborting? |
I'm fine with it not working if there is a port conflict, but after the appropriate log about the port conflict error, execution continues:
I'd have to test this flow again, since I killed the other service that was bound to 8025, but even with the above log, the server wasn't being hosted on https://127.0.0.1:8412. That's why I think execution should just exit 1 if a port is bound to instead of continuing. |
Closed
groob
added a commit
to groob/kolide-quickstart
that referenced
this issue
Feb 15, 2017
Closes kolide#15
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I had 8025 bound already and run
demo.sh up
and got an appropriate error message for the bound port, but the script continued and the webserver did not ultimately bind to the claimed port.The text was updated successfully, but these errors were encountered: