Parse subscriptionError also for dvr entries #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good.
I don't think it makes sense to attempt to map any other errors to a |
49b5377
to
8bcb602
Compare
8bcb602
to
777a99d
Compare
|
@ksooo good to go? |
|
@Jalle19 shove it in. |
Jalle19
added a commit
that referenced
this pull request
Oct 22, 2015
Parse subscriptionError also for dvr entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when an active recording isn't running because there is no free adapter available,
kodi will still show the timer as 'recording' (status field in timers window).
Now, for active recordings we can parse 'subscriptionError' as each active recording will have an active subscription. If 'subscriptionError' returns 'noFreeAdapter' we flag the timer state to 'PVR_TIMER_STATE_CONFLICT_NOK' and kodi will show 'conflict' as status in the timers window now.
No free adapter is practically the same as a conflict in my eyes..
Additionally we could also parse the other errors like scrambled, no signal etc and show them as error in the kodi GUI, what do you think?
https://github.com/xbmc/xbmc/blob/master/xbmc/addons/include/xbmc_pvr_types.h#L192