Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

08 integration #4

Merged
merged 5 commits into from
Jun 9, 2021
Merged

08 integration #4

merged 5 commits into from
Jun 9, 2021

Conversation

vgonda
Copy link
Member

@vgonda vgonda commented May 31, 2021

The primary changes you'll see over this and the next chapter include:

  • Make changes so chapter 8 flows into 9. Previously the sample projects different from the end of one to the start of the other
  • Use view binding and material design
  • Move dexmaker to chapter 9

@vgonda
Chapter 8 versions and lint
1719919
@vgonda
Update chapter 8 starter project
6b96baf 
Make changes so chapter 8 flows into 9
Use view binding and material design
Use mockito-android over dexmaker
@vgonda
All the same changes for the final project
cc1fc09
@vgonda
Add missing Copyright
df93514
@vgonda vgonda requested a review from jonathanwong May 31, 2021 17:42
jonathanwong
jonathanwong approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@jonathanwong jonathanwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jonathanwong jonathanwong merged commit 2a51f22 into editions/2.0 Jun 9, 2021
@jonathanwong jonathanwong deleted the 08-integration branch June 9, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanwong jonathanwong jonathanwong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vgonda @jonathanwong