Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI file playback support #56

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ishland
Copy link
Contributor

@ishland ishland commented Aug 23, 2020

Closes #24

@ishland ishland marked this pull request as ready for review January 2, 2021 14:20
@ishland ishland changed the title [WIP] Full-precision midi support MIDI file playback support Jan 2, 2021
@mibby
Copy link

mibby commented Feb 2, 2021

Is this currently implemented in any player for testing or just API additions for future use?

Edit: Assuming not yet, but if @koca2000 can merge the PR (if it's ready), MusicBox plugin would be one of the first to implement testing support once merged.

@ishland
Copy link
Contributor Author

ishland commented Feb 4, 2021

Is this currently implemented in any player for testing or just API additions for future use?

It is currently implemented and works just fine in my testings.
Currently theres are still some apis which is not working when playing midi files but I am working on it.

@mibby
Copy link

mibby commented Feb 5, 2021

I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again.

@ishland
Copy link
Contributor Author

ishland commented Feb 5, 2021

I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again.

I got a modified JukeBox plugin here.
jukebox.zip

@koca2000
Copy link
Owner

koca2000 commented Feb 5, 2021

I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again.

Hi! This is just one of the possible variants of implementation. The final change won't break other plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIDI support
3 participants