[WIP] dtrace support #222
Closed
[WIP] dtrace support #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd definitely prefer if we worked this sort of thing in as a plugin, and supported alternatives like ktap |
|
also so #219 for similar |
|
Sounds good to me! How should we do this - i'd like to help? |
|
For these simpler cases we could maybe just add a few events, but for the issue I have open there we'd need to get a hook system of some kind into koajs/compose. Even for the tracing case I think instrumenting the first middleware would be just as good as hooking into this core middleware, so we should be fine without the events |
|
Okay, love the idea! Will rework this tomorrow. |
|
Current progress: https://github.com/gergelyke/koa-dtrace |
|
closing since we have an issue for a compose hook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, as this part of Node 0.11 is unstable and subject to change.
Although all feedbacks are appreciated!