-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update statuses to v2.0.1 #1480
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 5 5
Lines 507 507
Branches 142 142
=======================================
Hits 505 505
Misses 2 2
Continue to review full report at Codecov.
|
https://github.com/jshttp/statuses/blob/master/HISTORY.md#200--2020-04-19 looks like this upgrade contains incompatible changes |
Kindly, can you tell me which change is incompatible and I will see what I can do. |
test/application/respond.js
Outdated
@@ -374,7 +374,7 @@ describe('app.respond', () => { | |||
describe('with custom status=700', () => { | |||
it('should respond with the associated status message', async() => { | |||
const app = new Koa(); | |||
statuses['700'] = 'custom status'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change for users who want to customize status code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we need to provide a more controllable way to customize status code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change for users who want to customize status code
According to what I understand form you, we should leave this PR to Koa@3 !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we need to provide a more controllable way to customize status code.
Perhaps we can provide a method to store, set, cache.. custom messages for custom codes.
I think this approach is simple and clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to latest version v2.0.1 🚀!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathanong @dougwilson @dead-horse @fengmk2
Hello guys, take a look if this is considered as a breaking change you can create a PR for koa v3.x where I can compare it or make a label for v3.x ...!
No description provided.