Fixed incorrect example of ctx.onerror usage #1459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://koajs.com/#stream provides the following example on how to handle errors in koa handler:
but this example is buggy. Consider the following code:
If you will execute
curl http:https://localhost:12345/get
it will result in exception:That's because
.on('error', ctx.onerror)
will callonerror
with different context, notctx
. That context doesn't haveapp
property (koa/lib/context.js
Line 121 in 8d52105
I have updated docs to preserve context.