attach responded to the socket

docs/api/index.md

@@ -248,6 +248,8 @@ Note:
  })
  ```
 
+ Note: `respond` event may not be emitted in case of premature socket close (due to a middleware timeout, for example).
+
 ### Event: 'responded'
 
  Emitted when the response stream is finished. Good place to cleanup any resources attached to `ctx.state` for example:

lib/application.js

@@ -164,14 +164,15 @@ module.exports = class Application extends Emitter {
  if (null != err) {
  ctx.onerror(err);
  this.emit(responding);
- } else this.emit('responded', ctx);
+ }
  };
  const handleResponse = () => {
  this.emit(responding);
  respond(ctx);
  };
  this.emit('request', ctx);
  onFinished(res, onerror);
+ onFinished(ctx.socket, () => { this.emit('responded', ctx); });
  return fnMiddleware(ctx).then(handleResponse).catch(onerror);
  }
 

test/application/events.js

@@ -69,4 +69,24 @@ describe('app emits events', () => {
  assert.deepStrictEqual(emitted, ['request', 'error', 'respond', 'responded']);
  assert.strictEqual(onceEvents, 1);
  });
+
+ it('should emit correct events on middleware timeout', async() => {
+ const app = new Koa();
+ const emitted = [];
+ ['request', 'respond', 'responded', 'error', 'timeout'].forEach(event => app.on(event, () => emitted.push(event)));
+
+ app.use(async(ctx, next) => {
+ await new Promise(resolve => setTimeout(resolve, 2000));
+ ctx.body = 'Timeout';
+ });
+
+ const server = app.listen();
+ server.setTimeout(1000, socket => { app.emit('timeout'); socket.end('HTTP/1.1 408 Request Timeout\r\n\r\n'); });
+
+ await request(server)
+ .get('/')
+ .expect(408);
+
+ assert.deepStrictEqual(emitted, ['request', 'responded', 'timeout']);
+ });
 });