refactor: remove duplicate assignment in respond test #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clark Du <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1055 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 5 5
Lines 369 369
=======================================
Hits 368 368
Misses 1 1Continue to review full report at Codecov.
|
dead-horse
reviewed
Sep 12, 2017
| @@ -544,7 +544,6 @@ describe('app.respond', () => { | |||
| ctx.length = fs.readFileSync('package.json').length; | |||
| const stream = fs.createReadStream('package.json'); | |||
| ctx.body = stream; | |||
| ctx.body = stream; | |||
There was a problem hiding this comment.
from the description of this test case(should keep content-length if overwritten with the same stream), I think we should not delete this line here.
There was a problem hiding this comment.
right, sorry I missed the case description
jonathanong
added a commit
that referenced
this pull request
Sep 12, 2017
This reverts commit c161c0f.
jonathanong
added a commit
that referenced
this pull request
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.