Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve consistency in api code examples #1029

Merged
merged 1 commit into from
Jul 21, 2017
Merged

improve consistency in api code examples #1029

merged 1 commit into from
Jul 21, 2017

Conversation

saadq
Copy link
Contributor

@saadq saadq commented Jul 19, 2017

Fix some minor inconsistencies in the docs:

  • Use arrow functions throughout
  • Consistent brace/semicolon/parens style
  • Only accept next as a parameter if it needs to be called
  • Use async functions throughout

Let me know if you'd like me to revert an of these.

@codecov
Copy link

codecov bot commented Jul 19, 2017

Codecov Report

Merging #1029 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1029   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           5        5           
  Lines         369      369           
=======================================
  Hits          368      368           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c44c11...15ae071. Read the comment docs.

@jonathanong jonathanong merged commit 40a6dd2 into koajs:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants