Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates documentation to include reference for RFC2324 (HTTP Status 418) #1028

Merged
merged 2 commits into from
Jul 19, 2017

Conversation

TzviPM
Copy link
Contributor

@TzviPM TzviPM commented Jul 19, 2017

https://www.ietf.org/rfc/rfc2324.txt clearly identifies status code 418 as a viable HTTP status code.

Also, the underlying statuses library does include it as a viable error response code, on line 42 of codes.json (https://github.com/jshttp/statuses/blob/master/codes.json#L42). Coincidentally, 42 is the secret to life in the hit book series and film The Hitchhiker's Guide to the Galaxy.

@codecov
Copy link

codecov bot commented Jul 19, 2017

Codecov Report

Merging #1028 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1028   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           5        5           
  Lines         369      369           
=======================================
  Hits          368      368           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6763021...c29d487. Read the comment docs.

@jonathanong jonathanong merged commit 0c44c11 into koajs:master Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants