Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to koa-body's latest syntax to access files in multipart example #129

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Update to koa-body's latest syntax to access files in multipart example #129

merged 1 commit into from
Jan 20, 2019

Conversation

zachary95
Copy link
Contributor

@zachary95 zachary95 commented Jan 17, 2019 •
edited
Loading

This PR fix where koa-body stores the files in latest version on the ctx.

@hemanth hemanth merged commit 104b9f7 into koajs:master Jan 20, 2019
@zachary95 zachary95 deleted the patch-1 branch January 23, 2019 02:04
@weisiwu
Copy link

weisiwu commented Feb 13, 2019 •
edited
Loading

it will cause a problem in my computer. here is the detail:
image
when i change code as so
image
it will work correctly.
my env info:
node v8.12.0
npm [email protected]
koa 2.7.0

@hemanth
Copy link
Member

hemanth commented Feb 13, 2019

you mean to say with ctx.request.files it fails and with ctx.request.body.files it passed?

@weisiwu
Copy link

weisiwu commented Feb 14, 2019

@hemanth yes, as you say.

@zachary95
Copy link
Contributor Author

Ok, I know why. Pushing a fix in a separated PR

@zachary95 zachary95 mentioned this pull request Feb 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zachary95 @weisiwu @hemanth