Make Identifier.set_value work with inherited properties #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmhunt
reviewed
Oct 24, 2021
There was a problem hiding this comment.
@danieldickison Thanks for the PR! Are you ok fixing up the set_value test and adding a couple tests to the spec?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindingContext.lookupworks with properties that are inherited through an object's prototype chain, butIdentifer.set_valuedoes not, which leads to asymmetrical behavior with bindings that read/write to an observable that’s inherited. This PR updatesIdentifier.set_valueso that it works with inherited properties, in line with how knockout works.