Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename user container to main container #15330

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

EraKin575
Copy link

Fixes #15007

Proposed Changes

*Renamed all UserContainer occurences to MainContainer in pkg package
*
*

Release Note


Copy link

knative-prow bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EraKin575
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

knative-prow bot commented Jun 17, 2024

Welcome @EraKin575! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2024
Copy link

knative-prow bot commented Jun 17, 2024

Hi @EraKin575. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 17, 2024
@knative-prow knative-prow bot requested review from dprotaso and skonto June 17, 2024 02:30
@EraKin575 EraKin575 changed the title rename container to main container rename user container to main container Jun 17, 2024
@EraKin575 EraKin575 closed this Jun 17, 2024
@EraKin575 EraKin575 reopened this Jun 25, 2024
@dprotaso
Copy link
Member

/hold we shouldn't be duplciating work

#15007 (comment)

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
@EraKin575
Copy link
Author

@dprotaso I think we can remove this from hold now

@dprotaso
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (af2c899) to head (5b1179f).

Current head 5b1179f differs from pull request most recent head 3fec7ce

Please upload reports for the commit 3fec7ce to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15330      +/-   ##
==========================================
- Coverage   84.61%   84.59%   -0.02%     
==========================================
  Files         219      219              
  Lines       13584    13584              
==========================================
- Hits        11494    11492       -2     
- Misses       1724     1726       +2     
  Partials      366      366              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,4 +1,4 @@
# Development
# Development
Copy link
Contributor

@skonto skonto Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the space?

// specified by the user, if `name:` is omitted.
DefaultUserContainerName = "user-container"
DefaultMainContainerName = "user-container"
Copy link
Contributor

@skonto skonto Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it user-container or main-container? Are we planning to change the actual value? If so what will be the autogenerated name?

@ReToCode
Copy link
Member

ReToCode commented Jul 1, 2024

Also before doing the actual rename of constants here, I'd start with checking the first points in #15007. Can ALL the occurences (including the actual values) in serving, pkg and docs be changed without breaking any public API? Only if the answer is true, we should actually rename stuff.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename UserContainer to ServingContainer
5 participants