Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /tmp and /var/log from reserved paths (#14686) #14719

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

jacksgt
Copy link
Contributor

@jacksgt jacksgt commented Dec 8, 2023

Fixes #14686

Proposed Changes

As discussed in #14686, the runtime contract REQUIRES /tmp to be a read-writeable folder and /var/log MAY BE writeable.
Since this can be achieved with many different means users should be able to mount volumes at these locations (e.g. /tmp for sharing data between containers, /var/log for shipping logs with a sidecar etc.)

/tmp MUST be Read-write. SHOULD be backed by tmpfs if disk load is a concern.
/var/log MAY be a directory with write permissions for logs storage. Implementations MAY permit the creation of additional subdirectories and log rotation and renaming.

https://github.com/knative/specs/blob/a8e7926c041baa58366f4939df9f3fdc866dbbb5/specs/serving/runtime-contract.md#default-filesystems

Release Note

Remove /tmp and /var/log from reserved paths

@knative-prow knative-prow bot added the area/API API objects and controllers label Dec 8, 2023
Copy link

knative-prow bot commented Dec 8, 2023

Welcome @jacksgt! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2023
@knative-prow knative-prow bot requested review from nak3 and psschwei December 8, 2023 08:48
Copy link

knative-prow bot commented Dec 8, 2023

Hi @jacksgt. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2024
@dprotaso
Copy link
Member

Hey thanks for the PR - you'll want to update the tests

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@jacksgt
Copy link
Contributor Author

jacksgt commented Jan 15, 2024

@dprotaso Thanks for the hint, I adjusted the tests. CI passed now.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (514e466) 86.08% compared to head (01a70b2) 86.00%.
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14719      +/-   ##
==========================================
- Coverage   86.08%   86.00%   -0.08%     
==========================================
  Files         197      197              
  Lines       14937    14950      +13     
==========================================
  Hits        12858    12858              
- Misses       1770     1780      +10     
- Partials      309      312       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
Copy link

knative-prow bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, jacksgt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1e2faa3 into knative:main Jan 15, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is /tmp a reserved path
2 participants