Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-istio nightly #14706

Merged

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Dec 5, 2023

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-istio.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-istio/latest/$x > ${GITHUB_WORKSPACE}/./third_party/istio-latest/$x
done

Details:

bumping knative.dev/net-istio ca16070...04509ce:
  > 04509ce Add K8s 1.29 testing and bump github actions (# 1241)
  > c57f453 Update community files (# 1242)
  > a5b1f5c upgrade to latest dependencies (# 1236)
  > 34c78f0 Update community files (# 1235)
  > fbee9c0 Replace deprecated sets usages with generic version (# 1234)
  > f87389c upgrade to latest dependencies (# 1233)
  > 5db6d0f Update community files (# 1232)
  > 373ba92 Update community files (# 1230)
  > d0708dd upgrade to latest dependencies (# 1231)
  > fadb996 upgrade to latest dependencies (# 1229)
  > 4af3076 upgrade to latest dependencies (# 1225)
  > 6899886 Use ko label filter instead of removing KnativeCertificate yaml (# 1224)
  > e6e6cb7 Update net-istio to use `KnativeCertificate` instead of control-protocol secret (# 1221)
  > b3007f4 upgrade to latest dependencies (# 1223)

@knative-prow knative-prow bot requested a review from a team December 5, 2023 11:05
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/networking labels Dec 5, 2023
@skonto
Copy link
Contributor

skonto commented Dec 5, 2023

/retest

@ReToCode
Copy link
Member

ReToCode commented Dec 6, 2023

/hold

This needs #14610 to work.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5602d7) 86.02% compared to head (a08915c) 86.04%.
Report is 7 commits behind head on main.

❗ Current head a08915c differs from pull request most recent head 0e7d154. Consider uploading reports for the commit 0e7d154 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14706      +/-   ##
==========================================
+ Coverage   86.02%   86.04%   +0.02%     
==========================================
  Files         197      197              
  Lines       14950    14950              
==========================================
+ Hits        12860    12864       +4     
+ Misses       1777     1775       -2     
+ Partials      313      311       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ReToCode added a commit to ReToCode/serving that referenced this pull request Dec 7, 2023
@knative-automation knative-automation force-pushed the update-nightly/net-istio branch 2 times, most recently from e4a4b7a to 4d48cc8 Compare December 8, 2023 06:21
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 8, 2023
@ReToCode
Copy link
Member

ReToCode commented Dec 8, 2023

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@ReToCode
Copy link
Member

ReToCode commented Dec 8, 2023

/hold

This still needs #14610 to work.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
ReToCode added a commit to ReToCode/serving that referenced this pull request Dec 8, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
ReToCode added a commit to ReToCode/serving that referenced this pull request Dec 12, 2023
@knative-automation knative-automation force-pushed the update-nightly/net-istio branch 3 times, most recently from 8125391 to 09e0539 Compare December 14, 2023 11:05
@knative-automation knative-automation force-pushed the update-nightly/net-istio branch 3 times, most recently from 24439ae to 1d49f67 Compare January 11, 2024 11:05
ReToCode added a commit to ReToCode/serving that referenced this pull request Jan 11, 2024
bumping knative.dev/net-istio ca16070...04509ce:
  > 04509ce Add K8s 1.29 testing and bump github actions (# 1241)
  > c57f453 Update community files (# 1242)
  > a5b1f5c upgrade to latest dependencies (# 1236)
  > 34c78f0 Update community files (# 1235)
  > fbee9c0 Replace deprecated sets usages with generic version (# 1234)
  > f87389c upgrade to latest dependencies (# 1233)
  > 5db6d0f Update community files (# 1232)
  > 373ba92 Update community files (# 1230)
  > d0708dd upgrade to latest dependencies (# 1231)
  > fadb996 upgrade to latest dependencies (# 1229)
  > 4af3076 upgrade to latest dependencies (# 1225)
  > 6899886 Use ko label filter instead of removing KnativeCertificate yaml (# 1224)
  > e6e6cb7 Update net-istio to use `KnativeCertificate` instead of control-protocol secret (# 1221)
  > b3007f4 upgrade to latest dependencies (# 1223)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jan 15, 2024
@dprotaso
Copy link
Member

Want to unblock this PR - so I've disabled the system internal tls tests for Istio

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
Copy link

knative-prow bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-automation, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@dprotaso
Copy link
Member

/hold cancel
/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 15, 2024
@dprotaso
Copy link
Member

kapp: Error: waiting on reconcile customresourcedefinition/certificaterequests.cert-manager.io (apiextensions.k8s.io/v1) cluster:
Errored:
Getting resource customresourcedefinition/certificaterequests.cert-manager.io (apiextensions.k8s.io/v1) cluster:
API server says: an error on the server ("Internal Server Error: "/apis/apiextensions.k8s.io/v1/customresourcedefinitions/certificaterequests.cert-manager.io": the server is currently unable to handle the request") has prevented the request from succeeding (reason: InternalError)

/retest

@dprotaso
Copy link
Member

weird - istio-tls jobs are failing

@dprotaso
Copy link
Member

/retest

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@dprotaso
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@dprotaso
Copy link
Member

Going to disable that as well - since it requires system-internal-tls

@knative-prow knative-prow bot merged commit 3cea8b4 into knative:main Jan 16, 2024
48 checks passed
ReToCode added a commit to ReToCode/serving that referenced this pull request Jan 16, 2024
knative-prow bot pushed a commit that referenced this pull request Jan 25, 2024
* use Knative certificates for Serving encryption

* Make namespace the owner of the Queue-Proxy certificate

* Lint error fixes

* Minor fixes

* cherry-pick #14706

* keep existing secret in upgrade/downgrade tests

* Rebase and update to upstream/main

* Review improvements

* Update net-istio

* Use a revision tracker to reconcile on KCerts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants