Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automated] Update net-kourier nightly #14613

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[Automated] Update net-kourier nightly #14613

merged 1 commit into from
Nov 10, 2023

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in kourier.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-kourier/latest/$x > ${GITHUB_WORKSPACE}/./third_party/kourier-latest/$x
done

Details:

bumping knative.dev/net-kourier fb8da93...ad58d90:
  > ad58d90 upgrade to latest dependencies (# 1155)

@knative-automation
Update net-kourier nightly
9bfc33d 
bumping knative.dev/net-kourier fb8da93...ad58d90:
  > ad58d90 upgrade to latest dependencies (# 1155)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot requested a review from a team November 10, 2023 11:05
@knative-prow knative-prow bot added area/networking size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17fa595) 86.04% compared to head (9bfc33d) 86.02%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14613      +/-   ##
==========================================
- Coverage   86.04%   86.02%   -0.03%     
==========================================
  Files         197      197              
  Lines       14916    14916              
==========================================
- Hits        12835    12832       -3     
- Misses       1772     1774       +2     
- Partials      309      310       +1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

psschwei
psschwei reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/test istio-latest-no-mesh

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@knative-prow knative-prow bot merged commit 6978eea into knative:main Nov 10, 2023
77 checks passed
andrew-delph added a commit to andrew-delph/serving that referenced this pull request Nov 24, 2023
@andrew-delph
surface deployment timeout - route active
f4f6b55 
modify rest of ut

Update net-kourier nightly (knative#14605)

bumping knative.dev/net-kourier 6e4d79d...fb8da93:
  > fb8da93 upgrade to latest dependencies (# 1151)

Signed-off-by: Knative Automation <[email protected]>

Update net-gateway-api nightly (knative#14602)

bumping knative.dev/net-gateway-api a8d56a3...0aa321a:
  > 0aa321a upgrade to latest dependencies (# 579)

Signed-off-by: Knative Automation <[email protected]>

upgrade to latest dependencies (knative#14608)

bumping knative.dev/pkg 5c9b7a8...35011d4:
  > 35011d4 upgrade to latest dependencies (# 2892)
bumping knative.dev/networking 18529fd...e0bee34:
  > e0bee34 upgrade to latest dependencies (# 889)
bumping knative.dev/hack 8834794...5deadde:
  > 5deadde 🐛 Set latest release only when publishing to Github (# 346)
bumping knative.dev/caching c642577...b3781bc:
  > b3781bc upgrade to latest dependencies (# 806)

Signed-off-by: Knative Automation <[email protected]>

Update net-contour nightly (knative#14612)

bumping knative.dev/net-contour 467a573...d2054f2:
  > d2054f2 upgrade to latest dependencies (# 999)

Signed-off-by: Knative Automation <[email protected]>

Update net-certmanager nightly (knative#14611)

bumping knative.dev/net-certmanager 11e6219...8b2a470:
  > 8b2a470 upgrade to latest dependencies (# 625)
  > 2248405 upgrade to latest dependencies (# 624)

Signed-off-by: Knative Automation <[email protected]>

Update net-kourier nightly (knative#14613)

bumping knative.dev/net-kourier fb8da93...ad58d90:
  > ad58d90 upgrade to latest dependencies (# 1155)

Signed-off-by: Knative Automation <[email protected]>

Update net-istio nightly (knative#14614)

bumping knative.dev/net-istio 7f77e97...e3db912:
  > e3db912 upgrade to latest dependencies (# 1209)
  > 1e021c8 upgrade to latest dependencies (# 1208)

Signed-off-by: Knative Automation <[email protected]>

Update net-gateway-api nightly (knative#14616)

bumping knative.dev/net-gateway-api 0aa321a...29bf0b9:
  > 29bf0b9 upgrade to latest dependencies (# 581)
  > cd26216 upgrade to latest dependencies (# 580)

Signed-off-by: Knative Automation <[email protected]>

Surface cpu and mem requests forbidden errors (and other ones too) in KSVC creation (knative#14453)

* reconciling the revision so the deployment status is propagated when there is something wrong (like low resources request and limits), since it was just beign propagated when the revision status was nil and the deployment existed

trying to surface replicaset creation errors

* added revision condition active to revision live condition set so is not nil after the revision is created

* removing RevisionConditionActive from Revision ConditionSet since we can have Ready Inactive Revisions (scale to zero) * added docs and tests for this and the replicaset failure propagation

* fixing lint

* adjusted e2e and unit tests for the replica failure erros propagation, improved propagation logic + left todos regarding revision conditionset

* removed todo from revision lifecycle since the discussion has settled

* added test case for revision fast failures when it comes to replicaset failing to create

* fixed resource quota error, now it never waits for progress deadline and it fails fast, so removing the bits where it can go one way or another in the e2e resource_quota_error_test

* finishing the replicaset deployment status failure bubbling up to the revision table test

* removed unused test methods from revision testing package

* adding condition to wait for container creation in the resource quota service creation test

* with some istio cases this could fail with progress deadline exceeded error so adding that case too

* Update resource_quota_error_test.go

* formated the test file

fix deploy-replicaset-failure UT

rename tests

remove coment

remove comment

wip

want go correct

need fix ScaleTargetInitialized

only extra patch

patch scale to 0

more test helper changes

new tc

ut

WithPubService

activation failure is unreachable

copy inactive condition

comments

comment

comment

refactor computeActiveCondition

allow scale to 0 with no metrics if unreachable

remoce comment

add UT: initial scale zero: with ready pods

change to 1 ready pod

replicas 1

change logic order

readd activeThreshold

change Failed message

scaler_test handle no metrics case

mend

silly typo

fix UT

shortten test cases

scale to 0 if unreachable comment + logic

remove controlls podinformer as its not needed

revert computeActiveCondition refactor

use reachability variables

init scale 0 stays no traffic

undo imports reorder

add comments

pa change Inactive reason to Unreachable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knative-automation @psschwei