Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support http1 full duplex per workload #14568

Merged
merged 10 commits into from
Jan 16, 2024
Merged

Support http1 full duplex per workload #14568

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5304ed6
support http1 full duplex per workload
skonto Oct 23, 2023
94e1651
lint
skonto Oct 26, 2023
71c220d
style
skonto Oct 26, 2023
5b21d8e
single call
skonto Nov 24, 2023
7ea1974
updates & unit test
skonto Nov 25, 2023
77f79ee
fix unit test
skonto Nov 25, 2023
fbe2861
fix comment
skonto Nov 29, 2023
c88d865
address review comments
skonto Dec 11, 2023
7d436e4
fix lint
skonto Dec 11, 2023
558ae15
skip for Mac
skonto Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix unit test
  • Loading branch information
@skonto
skonto committed Jan 15, 2024
commit 77f79eee00f7941650831462e4464866fe31d69d
1 change: 1 addition & 0 deletions pkg/activator/handler/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ func BenchmarkHandlerChain(b *testing.B) {
func TestProxyWithChainHandler(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the issue reproducer utilizing the activator's handler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this test in isolation it's not clear what it is doing - can you add a detailed comment and maybe link out to the knative and golang issue?

ctx, cancel, _ := rtesting.SetupFakeContextWithCancel(t)
rev := revision(testNamespace, testRevName)
defer reset()
rev.Annotations = map[string]string{apiconfig.AllowHTTPFullDuplexFeatureKey: "Enabled"}
t.Cleanup(cancel)

Expand Down