Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Bound buffer for reading stats #14542

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #14523

Applied an upper bound to the statistics data read from the queue-proxy by the autoscaler.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4ff7168) 86.26% compared to head (17084b7) 86.27%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11   #14542      +/-   ##
================================================
+ Coverage         86.26%   86.27%   +0.01%     
================================================
  Files               199      199              
  Lines             14814    14816       +2     
================================================
+ Hits              12779    12783       +4     
+ Misses             1734     1732       -2     
  Partials            301      301              
Files Coverage Δ
pkg/autoscaler/metrics/http_scrape_client.go 93.02% <100.00%> (+7.65%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 19, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@knative-prow knative-prow bot merged commit 012ee25 into knative:release-1.11 Oct 19, 2023
61 checks passed
openshift-ci bot pushed a commit to openshift-knative/serving that referenced this pull request Oct 20, 2023
* [release-1.11] fix securityContext for Knative Service Pod (user-container and queue-proxy) (knative#14378)

* add seccompProfile to queue container security context

* run as non root by default

* update tests to expect new default run as nonroot

---------

Co-authored-by: Clay Kauzlaric <[email protected]>

* Leave a comment which will trigger a new dot release (knative#14500)

* [release-1.11] bump x/net to v0.17 (knative#14516)

* [release-1.11] bump x/net to v1.17

* Re-generate test/config/tls/cert-secret.yaml (knative#14324)

* Run hack/update-codegen.sh --upgrade --release 1.11

* Bound buffer for reading stats (knative#14542)

Co-authored-by: Evan Anderson <[email protected]>

---------

Co-authored-by: Knative Prow Robot <[email protected]>
Co-authored-by: Clay Kauzlaric <[email protected]>
Co-authored-by: Kenjiro Nakayama <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Jan 8, 2024
* [release-1.11] fix securityContext for Knative Service Pod (user-container and queue-proxy) (knative#14378)

* add seccompProfile to queue container security context

* run as non root by default

* update tests to expect new default run as nonroot

---------

Co-authored-by: Clay Kauzlaric <[email protected]>

* Leave a comment which will trigger a new dot release (knative#14500)

* [release-1.11] bump x/net to v0.17 (knative#14516)

* [release-1.11] bump x/net to v1.17

* Re-generate test/config/tls/cert-secret.yaml (knative#14324)

* Run hack/update-codegen.sh --upgrade --release 1.11

* Bound buffer for reading stats (knative#14542)

Co-authored-by: Evan Anderson <[email protected]>

* upgrade to latest dependencies (knative#14552)

bumping knative.dev/pkg bd99f2f...56bfe0d:
  > 56bfe0d [release-1.11] [CVE-2023-44487] Disable http2 for webhooks (# 2875)
bumping knative.dev/caching 24ff723...ee89f75:
  > ee89f75 upgrade to latest dependencies (# 797)

Signed-off-by: Knative Automation <[email protected]>

* Upgrade grpc for addressing GHSA-m425-mq94-257g (knative#14579)

More info at GHSA-m425-mq94-257g

* remove duplicate 'additionalPrinterColumns' (knative#14654)

Signed-off-by: Kenny Leung <[email protected]>
Co-authored-by: Kenny Leung <[email protected]>

* [release-1.11] Bump to fix knative#14732 (knative#14734)

* Bump to fix knative#14732

* Bump to fix serving/knative#14732

* Sync with upstream release-1.11

---------

Signed-off-by: Knative Automation <[email protected]>
Signed-off-by: Kenny Leung <[email protected]>
Co-authored-by: Knative Prow Robot <[email protected]>
Co-authored-by: Clay Kauzlaric <[email protected]>
Co-authored-by: Kenjiro Nakayama <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Knative Automation <[email protected]>
Co-authored-by: Juan Sanin <[email protected]>
Co-authored-by: Kenny Leung <[email protected]>
Co-authored-by: Dave Protasowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants